colr: make non-exhaustive, add unit tests#149
Conversation
bradh
force-pushed
the
nclc_follow_up_2026-04-02
branch
from
7d51f4c to
9fd4f91
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change annotates the public 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/moov/trak/mdia/minf/stbl/stsd/colr.rs`:
- Around line 189-193: The test function test_nclc_decode in colr.rs has array
literals missing trailing commas which causes cargo fmt --check to fail; update
the byte array ENCODED (and the other arrays mentioned around lines 211-214 and
216-220) to include trailing commas after the last elements so rustfmt passes
(locate the ENCODED array inside fn test_nclc_decode and the other similar test
arrays and add a trailing comma after the final byte in each array literal).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b20f239a-fa0e-402b-8309-a7d5dd8d7523
📒 Files selected for processing (1)
src/moov/trak/mdia/minf/stbl/stsd/colr.rs
1 participant
Follow-up for #110, to add tests and make
colrnon-exhaustive per @kixelated comment at #110 (comment)@libark does this look OK to you?